Feat/webview bridge #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Route 데이터에 맞춰 해당 페이지로 이동 - FE 미배포로 디테일한 내용은 추후 구현
soopeach
reviewed
Sep 8, 2023
Comment on lines
38
to
40
| when(JSONObject(data).getString("route")) { | ||
| Route.EDIT_RESTAURANT.route-> { | ||
| val restaurantId = JSONObject(data).getString("restaurantId").toInt() |
There was a problem hiding this comment.
JSONObject(data)를 함수 내의 최상위 변수로 두면 중복을 줄일 수 있을 것 같아요!
| // webView.canGoBack으로 뒤로가기 처리 완료해서 비워뒀습니다. |
There was a problem hiding this comment.
오..!! 그럼 알아서 백버튼 눌렀을 때 클라이언트 네비게이션 기준 backstack이 비워지는건가요?
There was a problem hiding this comment.
아하 아래 코드를 보니... webview자체에 goback이라는 메서드가 있군요
| import org.gdsc.presentation.model.Route | ||
| import org.json.JSONObject | ||
|
|
||
| const val WEB_BASE_URL = "https://jmt-matzip.dev/detail/" |
There was a problem hiding this comment.
어 근데 이거 Base Url 인데 detail 이 포함되는게 맞나요??
| // 주소는 변경 되어야 함, 현재는 Lucy LocalHost 테스트 | ||
| intent.putExtra( | ||
| "url", | ||
| "http://172.20.10.13:3000/detail/$restaurantId" | ||
| "$WEB_BASE_URL$restaurantId" |
There was a problem hiding this comment.
WEB_BASE_URL에 코멘트 남겨놨는데 그거 확인해보시고 변경사항있으면 요쪽도 수정같이 하면 될 것 같아요!
soopeach
approved these changes
Sep 10, 2023
soopeach
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
웹뷰 브릿지 연결
추가적으로 필요한 기능
비고